[openib-general] [PATCH] ib_addr: Handle Ethernet neighbour updates during route resolution.

[Sean Hefty]

Looks good to me.

Acked-by: Sean Hefty <sean.hefty at intel.com>

Steve Wise wrote:
> Handle Ethernet neighbour updates during route resolution.
> 
> The IWCM uses the ib_addr services to do route resolution (neighbour
> discovery in the IP world).  The ib_addr netevent callback routine,
> however, currently only acts on Inifininband neighbour updates.  It needs
> to act on ethernet neighbour updates as well.
> 
> This patch just removes filtering on device type altogether and
> will trigger on any neighour updates where the nud_type is valid.
> This simplifies the code some.
> 
> Signed-off-by: Steve Wise <swise at opengridcomputing.com>
> ---
> 
>  drivers/infiniband/core/addr.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/infiniband/core/addr.c b/drivers/infiniband/core/addr.c
> index af93979..d2bb5a9 100644
> --- a/drivers/infiniband/core/addr.c
> +++ b/drivers/infiniband/core/addr.c
> @@ -360,8 +360,7 @@ static int netevent_callback(struct noti
>  	if (event == NETEVENT_NEIGH_UPDATE) {
>  		struct neighbour *neigh = ctx;
>  
> -		if (neigh->dev->type == ARPHRD_INFINIBAND &&
> -		    (neigh->nud_state & NUD_VALID)) {
> +		if (neigh->nud_state & NUD_VALID) {
>  			set_timeout(jiffies);
>  		}
>  	}