[openib-general] [PATCH 0/6] osm: QoS policy parser

[Sasha Khapyorsky]

On 16:50 Fri 26 Jan     , Michael S. Tsirkin wrote:
> > >>> As far as using lex/yacc, are they invoked as part of the build
> > >>> procedure or are the files they generate just checked in and used ?
> > >>>
> > >> When lex/yacc are invoked, they generate three files: 
> > >>   - osm_qos_parser_l.c
> > >>   - osm_qos_parser_y.c
> > >>   - osm_qos_parser_y.h
> > >> These generated files should be included in the git repository,
> > >> and they are the ones that are compiled by 'make' command.
> 
> By the way, a disadvantage of this approach is that git log becomes quite
> useless when you touch one of lex/yacc sources, logs are cluttered
> with unreadable diffs.
> 
> A general rule is to avoid keeping generated files under git.

Good rule.

> If you want to avoid dependance on yacc/lex
> on user's system, I think a better way would be to generate these
> during 'make dist', *not* have them tracked in git.

That seems better approach for me too.

Sasha