[openib-general] [PATCH] IPOIB: Use a GRH when appropriate for unicast packets

[Jason Gunthorpe]

On Thu, Jan 25, 2007 at 09:15:31PM -0800, Roland Dreier wrote:
>  > +		if ((ret = ib_init_ah_from_path(priv->ca,priv->port,pathrec,&av)))
> 
> kernel style is spaces after commas, like

Oops, I'll fix these style things and send a new patch.

>  > +			ipoib_dbg(priv, "PathRec init_ah failed %d for GID "
> 
> printing the error message with ipoib_dbg() is a good idea?  It means
> the failure will be invisible unless someone explicitly enables
> debugging.

I don't know. The other two users in the tree ignore the return
code right now..

>  > +			// FIXME: Should this be in ib_init_ah_from_path?
>  > +			av.static_rate = pathrec->rate;
> 
> Yes, I think this should be in ib_init_ah_from_path() ... I don't see
> any reason why it shouldn't.  I suspect the reason is historical,

OK.

> BTW do SRP and iSER already work through routers?

I haven't tried them, my current goal is to get RDMA CM working over
routers and then SDP. Right now the RDMA CM does not work. It looks
like it is not setting the hop limit properly but I haven't found out
where yet ..

Thanks,
Jason