[ofa-general] [PATCH 1/2] ib/sa: Add InformInfo/Notice support

[Sean Hefty]

>> +static void inform_event_handler(struct ib_event_handler *handler,
>> +				struct ib_event *event)
>> +{
>> +	struct inform_device *dev;
>> +
>> +	dev = container_of(handler, struct inform_device, event_handler);
>> +
>> +	switch (event->event) {
>> +	case IB_EVENT_PORT_ERR:
>> +	case IB_EVENT_LID_CHANGE:
>> +	case IB_EVENT_SM_CHANGE:
>> +	case IB_EVENT_CLIENT_REREGISTER:
>> +		inform_groups_lost(&dev->port[event->element.port_num -
>> +					      dev->start_port]);
>
>I think you want to act here only if event->element.port_num is the port
>this inform_device is associated with (similar to IPoIB), also the same
>for mcast_event_handler.

IPoIB registers its event handler per port, so requires the extra check.  Both
the multicast and inform info modules register their event handlers per device,
so the check isn't necessary.

- Sean