[ofa-general] [PATCH 8/8] IB/ipath -- remove bogus RD_ATOMIC checks from modify_qp

Arthur Jones arthur.jones at qlogic.com
Fri Jul 6 12:48:58 PDT 2007


The changeset:

  commit 3859e39d75b72f35f7d38c618fbbacb39a440c22
  Author: Ralph Campbell <ralph.campbell at qlogic.com>
  Date:   Thu Mar 15 14:44:51 2007 -0700

    IB/ipath: Support larger IB_QP_MAX_DEST_RD_ATOMIC and IB_QP_MAX_QP_RD_ATOMIC

    This patch adds support for multiple RDMA reads and atomics to be sent
    before an ACK is required to be seen by the requester.

    Signed-off-by: Bryan O'Sullivan <bryan.osullivan at qlogic.com>
    Signed-off-by: Roland Dreier <rolandd at cisco.com>

added support for the larger RD_ATOMICs, but it failed
to take out the stricter checks that were before these
and hence had no effect.  this patch takes out the bogus
checks...

Signed-off-by: Arthur Jones <arthur.jones at qlogic.com>
---

 drivers/infiniband/hw/ipath/ipath_qp.c |    8 --------
 1 files changed, 0 insertions(+), 8 deletions(-)

diff --git a/drivers/infiniband/hw/ipath/ipath_qp.c b/drivers/infiniband/hw/ipath/ipath_qp.c
index d317b81..1324b35 100644
--- a/drivers/infiniband/hw/ipath/ipath_qp.c
+++ b/drivers/infiniband/hw/ipath/ipath_qp.c
@@ -516,14 +516,6 @@ int ipath_modify_qp(struct ib_qp *ibqp, struct ib_qp_attr *attr,
 		if (attr->path_mtu > IB_MTU_2048)
 			goto inval;
 
-	if (attr_mask & IB_QP_MAX_DEST_RD_ATOMIC)
-		if (attr->max_dest_rd_atomic > 1)
-			goto inval;
-
-	if (attr_mask & IB_QP_MAX_QP_RD_ATOMIC)
-		if (attr->max_rd_atomic > 1)
-			goto inval;
-
 	if (attr_mask & IB_QP_PATH_MIG_STATE)
 		if (attr->path_mig_state != IB_MIG_MIGRATED &&
 		    attr->path_mig_state != IB_MIG_REARM)




More information about the general mailing list