[ofa-general] Re: [PATCH] IB/mad: fix duplicated kernel thread name

Michael S. Tsirkin mst at dev.mellanox.co.il
Mon Jul 16 23:21:59 PDT 2007


> Quoting Roland Dreier <rdreier at cisco.com>:
> Subject: Re: [PATCH] IB/mad: fix duplicated kernel thread name
> 
>  > The mad module creates thread per active port where the thread name is
>  > derived from the port name. This cause different threads to have same
>  > names when there are multiple devices. Fix that by using both the device
>  > and the port numbers to derive the name.
> 
> What problem does the duplicate name cause in the first place?

I don't really see a any serious problem this would cause.

However, creating a thread per port does seem
somewhat arbitrary, and would mean wasting (a small amount of) resources
apparently for no gain if there are lots of HCA ports in a box.

Further, renicing the mad thread to work around bug 229
<https://bugs.openfabrics.org/show_bug.cgi?id=229>
is easier if there's a fixed number of threads:
as it is, the threads come and go on hotplug,
so the renicing must be repeated on each hotplug event.
 
-- 
MST



More information about the general mailing list