[ofa-general] Re: [PATCH] IB/mlx4: enable MSI-X by default

[Roland Dreier]

 > +	mlx4_enable_msi_x(dev);
 > +
 >  	err = mlx4_init_hca(dev);
 > +	if (err == -EBUSY && (dev->flags & MLX4_FLAG_MSI_X)) {
 > +		mlx4_warn(dev, "Trying again with MSI/MSI-X disabled.\n");
 > +		dev->flags &= ~MLX4_FLAG_MSI_X;
 > +		pci_disable_msix(pdev);
 > +		err = mlx4_init_hca(dev);
 > +	}
 > +
 >  	if (err)
 >  		goto err_cmd;
 >  
 > +	mlx4_enable_msi_x(dev);
 > +

Am I misreading the code or is that last mlx4_enable_msi_x() wrong?

 - R.