[ofa-general] Re: [PATCH 04/10] net-sysfs.c changes.

[Krishna Kumar2]

Stephen Hemminger <shemminger at linux-foundation.org> wrote on 07/20/2007
09:52:03 PM:
> Patrick McHardy <kaber at trash.net> wrote:
>
> > Krishna Kumar2 wrote:
> > > Patrick McHardy <kaber at trash.net> wrote on 07/20/2007 03:37:20 PM:
> > >
> > >
> > >
> > >> rtnetlink support seems more important than sysfs to me.
> > >>
> > >
> > > Thanks, I will add that as a patch. The reason to add to sysfs is
that
> > > it is easier to change for a user (and similar to tx_queue_len).
> > >
> >
>
> But since batching is so similar to TSO, i really should be part of the
> flags and controlled by ethtool like other offload flags.

So should I add all three interfaces (or which ones) :

      1. /sys (like for tx_queue_len)
      2. netlink
      3. ethtool.

Or only 2 & 3 are enough ?

thanks,

- KK