[ofa-general] Re: [PATCH 05/10] sch_generic.c changes.

[Krishna Kumar2]

Krishna Kumar2/India/IBM wrote on 07/21/2007 12:26:23 PM:

> Hi Patrick,
>
> Patrick McHardy <kaber at trash.net> wrote on 07/20/2007 11:46:36 PM:
>
> > The check for tx_queue_len is wrong though,
> > its only a default which can be overriden and some qdiscs don't
> > care for it at all.

> I think it should not matter whether qdiscs use this or not, or even if
it
> is modified (unless it is made zero in which case this breaks). The
> intention behind this check is to make sure that not more than
tx_queue_len
> skbs are in all queues put together (q->qdisc + dev->skb_blist),
otherwise
> the blist can become too large and breaks the idea of tx_queue_len. Is
that
> a good justification ?

Also, if tx_queue_len is set to zero, I think my code will not execute and
the existing code will break at rc = q->enqueue() (for sched's checking
queue
limits).