[ofa-general] [PATCH resend] opensm/osm_indent:

Sasha Khapyorsky sashak at voltaire.com
Mon Jul 23 18:08:38 PDT 2007


On 21:05 Mon 23 Jul     , Eitan Zahavi wrote:
> Hi Sasha,
> 
> I read the new coding style doc after this last mail.

It was under RFC subject on the list couple of months ago...

> I thought you only defined new "indentation rules" and I am for doing
> this step as it is automatic and safe.
> But rewriting the code with shorter names and replacing all variables 
> and functions seems a little too risky in my mind.

Yes, the script enforces "indentation rules" only. I didn't think we will
be able to deal with rest stuff shortly (<= OFED 1.3). So currently it
is (1) OpenSM style definition and (2) recommendations for new code/files
style.

Sasha



More information about the general mailing list