[ofa-general] Re: add_open_iscsi_h.patch

[Michael S. Tsirkin]

> Quoting Erez Zilber <erezz at voltaire.com>:
> Subject: Re: add_open_iscsi_h.patch
> 
> Michael S. Tsirkin wrote:
> 
> > Erez, add_open_iscsi_h currently does:
> >
> > -#include <scsi/iscsi_if.h>
> > +#include "iscsi_if.h"
> >
> > why is ths bit needed?
> >
> 
> Strange. I remember that I couldn't build OFED 1.2 without it in the
> past. I tried to rebuild it without this now, and it compiles
> successfully, so let's remove that code.

On a related note:

 #include <linux/types.h>
 #include <linux/mutex.h>
-#include <linux/timer.h>
-#include <linux/workqueue.h>
 #include <scsi/iscsi_proto.h>
 #include <scsi/iscsi_if.h>


should not be needed too.


And how come this is helpful?

@@ -277,7 +277,6 @@ enum iscsi_param {
  * These flags describes reason of stop_conn() call
  */
 #define STOP_CONN_TERM         0x1
-#define STOP_CONN_SUSPEND      0x2
 #define STOP_CONN_RECOVER      0x3

 #define ISCSI_STATS_CUSTOM_MAX         32

In other words, is there a chance we can kill this patch completely?

-- 
MST