[ofa-general] Re: [PATCH trivial] include linux/mutex.h from scsi_transport_iscsi.h
Michael S. Tsirkin
mst at dev.mellanox.co.il
Wed Jul 25 12:12:57 PDT 2007
> Quoting Mike Christie <michaelc at cs.wisc.edu>:
> Subject: Re: [PATCH trivial] include linux/mutex.h from scsi_transport_iscsi.h
>
> Michael S. Tsirkin wrote:
> >scsi/scsi_transport_iscsi.h uses struct mutex, so while
> >linux/mutex.h seems to be pulled in indirectly
> >by one of the headers it includes, the right thing
> >is to include linux/mutex.h directly.
> >
>
> Is that part about always including the header directly right?
Think so. Analogous patches by me has been accepted in various
subsystems. See e.g. f8916c11a4dc4cb2367e9bee1788f4e0f1b4eabc.
> If so
> then were you going to include list.h too,
Makes sense. I'll repost.
> and were you going to fix up
> some of the other iscsi code?
Not at the moment.
The reason I noticed this is because I'm doing some other project.
I'll post patches for other files if/when I notice any issues.
--
MST
More information about the general
mailing list