[ofa-general] should the macro IB_UMEM_MAX_PAGE_CHUNK be removed from ib_verbs?

Dotan Barak dotanb at dev.mellanox.co.il
Tue Jul 31 07:04:07 PDT 2007


Hi Roland.

Here is the code of the macro IB_UMEM_MAX_PAGE_CHUNK (from ib_verbs):

#define IB_UMEM_MAX_PAGE_CHUNK                                          \
        ((PAGE_SIZE - offsetof(struct ib_umem_chunk, page_list)) /      \
         ((void *) &((struct ib_umem_chunk *) 0)->page_list[1] -        \
          (void *) &((struct ib_umem_chunk *) 0)->page_list[0]))



The problem is that the struct ib_umem_chunk is no longer in this header 
file (ib_verbs.h), the declaration
of this structure can be found in ib_umem.h.

This problem can be fixed by one of the following:
1) add include to ib_umem.h in ib_verbs.h
2) move this macro to ib_umem.h

what do you think?

thanks
Dotan



More information about the general mailing list