[ofa-general] RE: [PATCH] rdma_cm: fix port type (fix bug 557)

Yosef Etigin yosefe at voltaire.com
Tue Jun 5 23:11:48 PDT 2007


Sean Hefty wrote:
>>I haven't followed this closely, but what's the impact of this bug?
>>It seems it would result in a port out of the configured range being
>>used.  Which seems serious enough to fix for 2.6.22 to me.
> 
> 
> It can result in a port outside of the configured range, and its occurrence
> depends on the compiler used.  I've pushed my patch to:
> 
> 	git://git.openfabrics.org/~shefty/rdma-dev.git for-roland
> 
> which is based on 2.6.22-rc4.  Yosef, can you confirm that this patch works for
> you?
> 
> - Sean

Yes, it works.
Maybe we ahould use another variable ("unsigned coins;") to generate the random
bytes to, so next_port will not be used for two different purposes?

--Yossi




More information about the general mailing list