[ofa-general] RE: [PATCH] rdma_cm: fix port type (fix bug 557)

[Vladimir Sokolovsky]

Done,
Added kernel_patches/fixes/sean_cma_next_port_fix.patch

Regards,
Vladimir

On Wed, 2007-06-06 at 08:55 +0300, Tziporet Koren wrote:
> Sean Hefty wrote:
> > Vlad, can you please pull this change into OFED?
> >
> Approved
> 
> Tziporet
> 
> >> next_port should be between sysctl_local_port_range[0] and [1].  
> >> However,
> >> it is initially set to a random value.  If the value is negative, 
> >> next_port
> >> can fall outside of this range because of the % operator returning a
> >> negative value.
> >>
> >> Signed-off-by: Sean Hefty <sean.hefty at intel.com>
> >> ---
> >>
> >>  drivers/infiniband/core/cma.c |    4 ++--
> >>  1 files changed, 2 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/drivers/infiniband/core/cma.c 
> >> b/drivers/infiniband/core/cma.c
> >> index eb15119..b0831cb 100644
> >> --- a/drivers/infiniband/core/cma.c
> >> +++ b/drivers/infiniband/core/cma.c
> >> @@ -2772,8 +2772,8 @@ static int cma_init(void)
> >>      int ret;
> >>  
> >>      get_random_bytes(&next_port, sizeof next_port);
> >> -    next_port = (next_port % (sysctl_local_port_range[1] -
> >> -                  sysctl_local_port_range[0])) +
> >> +    next_port = ((unsigned int) next_port %
> >> +            (sysctl_local_port_range[1] - 
> >> sysctl_local_port_range[0])) +
> >>              sysctl_local_port_range[0];
> >>      cma_wq = create_singlethread_workqueue("rdma_cm");
> >>      if (!cma_wq)
> >>
> >>
> > _______________________________________________
> > general mailing list
> > general at lists.openfabrics.org
> > http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general
> >
> > To unsubscribe, please visit 
> > http://openib.org/mailman/listinfo/openib-general
> >
>