[ofa-general] Re: [PATCH] osm: up/dn ranking - making code more intuitive

Hal Rosenstock halr at voltaire.com
Mon Jun 11 15:59:53 PDT 2007


Hi Yevgeny,

On Mon, 2007-06-11 at 10:15, Yevgeny Kliteynik wrote:
> Hi Hal.
> 
> Following up our discussion with Sasha regarding the ranking 
> optimization in up/dn routing:
> 
> >> I do think that to make the code more "intuitive" we might  
> >> want to remove the __updn_update_rank() and do something like this:
> >>
> >>    if (remote_u->rank > u->rank + 1)
> >>    {
> >>        remote_u->rank = u->rank + 1;
> >>        max_rank = remote_u->rank; 
> >>        cl_qlist_insert_tail(&list, &remote_u->list);
> >>    }
>  
> Signed-off-by: Yevgeny Kliteynik <kliteyn at dev.mellanox.co.il>

Thanks. Applied.

-- Hal




More information about the general mailing list