[ofa-general] IPOB CM (NOSRQ) [PATCH V6] patch

[Sean Hefty]

>This function is called only when a REQ is received. Otherwise
>current_rc_qp is only used in the error case, or when the connection
>is being torn down. Hence I don't think it makes a significant
>difference which one is used.

I'm not hung up on this, but it appears that current_rc_qp is being used as an
atomic (read, inc, dec).  Converting it to an atomic seems cleaner.

>Move the closing "*/" to the next line?

The preferred format for multi-line comments is:

/*
 * first line
 * second line
 * etc.
 */

I don't know how well the existing code follows this format...

>>> +	if (p && time_after_eq(jiffies, p->jiffies + IPOIB_CM_RX_UPDATE_TIME)) {
>>> +		spin_lock_irqsave(&priv->lock, flags);
>>> +		p->jiffies = jiffies;
>>> +		/* Move this entry to list head, but do
>>> +		 * not re-add it if it has been removed. */
>>> +		if (!list_empty(&p->list))
>>
>> This line is the only difference between this function and the previous one.
>Is
>> it possible to always use the state check?
>
>The state check is only used in the SRQ case.

I guess I was just asking whether the non-SRQ case could be made to make use of
state as well.  (I'll leave that to you, since I'm not as familiar with the
code.  I was just looking for ways to make the SRQ/no-SRQ code common, but only
if it simplifies the code in the end.)

- Sean