[ofa-general] Re: [PATCH] management: uint -> unsigned replacement

[Hal Rosenstock]

On Tue, 2007-06-26 at 14:01, Sasha Khapyorsky wrote:
> On 16:24 Tue 26 Jun     , Michael S. Tsirkin wrote:
> > > Quoting Hal Rosenstock <halr at voltaire.com>:
> > > Subject: Re: [PATCH] management: uint -> unsigned replacement
> > > 
> > > On Tue, 2007-06-26 at 06:20, Michael S. Tsirkin wrote:
> > > > Some management headers use uint type which (on my system)
> > > 
> > > What's your system ?
> > 
> > SLES10.
> > 
> > > >  is described as "old
> > > > compatibility name for C type".  This type might not defined e.g. if
> > > > __STRICT_ANSI__ is set,
> > > 
> > > Is strict ANSI a requirement ?
> 
> Even if not,

I was just trying to determine how much further we needed to go down
this path.

-- Hal

>  what is a reason to use uint there instead of just unsigned?
> I don't know. I like this patch.
> 
> Sasha
> 
> > 
> > Not sure. The app in question does
> > #define _XOPEN_SOURCE 600
> > 
> > > >  so it is best to avoid its usage at least in headers.
> > > > Replace by unsigned in all headers.
> > > > 
> > > > Signed-off-by: Michael S. Tsirkin <mst at dev.mellanox.co.il>
> > > > 
> > > > ---
> > > > 
> > > > Hal can you apply this please? As a separate question:
> > > > I didn't go over .c files (we don't build them with strict ansi now),
> > > > but maybe removing uint there is a good idea, too?
> > > 
> > > Yes but it will take more than this to make them strict ANSI.
> > > 
> > > Is this as an OFED 1.2 follow on or just for master ?
> > 
> > You decide.
> > 
> > -- 
> > MST
> > _______________________________________________
> > general mailing list
> > general at lists.openfabrics.org
> > http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general
> > 
> > To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general