[ofa-general] [PATCH] 2.6.23 ib/ipath: return correct PortGUID in NodeInfo
Arthur Jones
arthur.jones at qlogic.com
Thu Jun 28 18:15:31 PDT 2007
hi sean, you did indeed pick out a bug, but
the fix is wrong:
On Thu, Jun 28, 2007 at 05:17:14PM -0700, Sean Hefty wrote:
> [...]
> >Return the PortGUID of the correct port when responding to a NodeInfo
> >query. Returning the SystemImageGUID causes issues when there are
> >multiple HCAs in a single system.
> >
> >Signed-off-by: Sean Hefty <sean.hefty at intel.com>
> >---
> >FYI - this patch will be included in my git pull request for 2.6.23 as
> >well.
> >
> > drivers/infiniband/hw/ipath/ipath_mad.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> >diff --git a/drivers/infiniband/hw/ipath/ipath_mad.c
> >b/drivers/infiniband/hw/ipath/ipath_mad.c
> >index 25908b0..3aec0b6 100644
> >--- a/drivers/infiniband/hw/ipath/ipath_mad.c
> >+++ b/drivers/infiniband/hw/ipath/ipath_mad.c
> >@@ -103,7 +103,7 @@ static int recv_subn_get_nodeinfo(struct ib_smp *smp,
> > /* This is already in network order */
> > nip->sys_guid = to_idev(ibdev)->sys_image_guid;
> > nip->node_guid = dd->ipath_guid;
> >- nip->port_guid = nip->sys_guid;
> >+ nip->port_guid = nip->ipath_guid;
this should be "nip->port_guid = dd->ipath_guid;". this
was pointed out by ralph campbell...
thanks for the fix, though!
arthur
More information about the general
mailing list