[ofa-general] Re: [PATCH] Chelsio RHEL4 U2/U3 Support.

[Andrew Friedley]

Michael S. Tsirkin wrote:

>>> This patch fixes the compile problems with Chelsio cxgb3 on RHEL4 U2/U3.
>> Looks like I have the problem for this fix on U4 as well, could this be 
>> applied there too?
> 
> what's the problem?
> 

My mistake -- I was told this was a U4 system, but the OFED install 
appears to be using the U3 backport patches.  However the error I see is 
different from the nightly automated build, though related:

/var/tmp/OFEDRPM/BUILD/ofa_kernel-1.2/drivers/net/cxgb3/cxgb3_offload.c:56: 
error: syntax error before "adapter_list_lock"
/var/tmp/OFEDRPM/BUILD/ofa_kernel-1.2/drivers/net/cxgb3/cxgb3_offload.c:56: 
warning: type defaults to `int' in declaration of `adapter_list_lock'
/var/tmp/OFEDRPM/BUILD/ofa_kernel-1.2/drivers/net/cxgb3/cxgb3_offload.c:56: 
error: incompatible types in initialization
/var/tmp/OFEDRPM/BUILD/ofa_kernel-1.2/drivers/net/cxgb3/cxgb3_offload.c:56: 
error: initializer element is not constant
/var/tmp/OFEDRPM/BUILD/ofa_kernel-1.2/drivers/net/cxgb3/cxgb3_offload.c:56: 
warning: data definition has no type or storage class
/var/tmp/OFEDRPM/BUILD/ofa_kernel-1.2/drivers/net/cxgb3/cxgb3_offload.c: 
In function `is_offloading':
/var/tmp/OFEDRPM/BUILD/ofa_kernel-1.2/drivers/net/cxgb3/cxgb3_offload.c:884: 
warning: passing arg 1 of `_read_lock_bh' from incompatible pointer type
/var/tmp/OFEDRPM/BUILD/ofa_kernel-1.2/drivers/net/cxgb3/cxgb3_offload.c:888: 
warning: passing arg 1 of `_read_unlock_bh' from incompatible pointer type
/var/tmp/OFEDRPM/BUILD/ofa_kernel-1.2/drivers/net/cxgb3/cxgb3_offload.c:893: 
warning: passing arg 1 of `_read_unlock_bh' from incompatible pointer type
/var/tmp/OFEDRPM/BUILD/ofa_kernel-1.2/drivers/net/cxgb3/cxgb3_offload.c: 
In function `add_adapter':
/var/tmp/OFEDRPM/BUILD/ofa_kernel-1.2/drivers/net/cxgb3/cxgb3_offload.c:1061: 
warning: passing arg 1 of `_write_lock_bh' from incompatible pointer type
/var/tmp/OFEDRPM/BUILD/ofa_kernel-1.2/drivers/net/cxgb3/cxgb3_offload.c:1063: 
warning: passing arg 1 of `_write_unlock_bh' from incompatible pointer type
/var/tmp/OFEDRPM/BUILD/ofa_kernel-1.2/drivers/net/cxgb3/cxgb3_offload.c: 
In function `remove_adapter':
/var/tmp/OFEDRPM/BUILD/ofa_kernel-1.2/drivers/net/cxgb3/cxgb3_offload.c:1068: 
warning: passing arg 1 of `_write_lock_bh' from incompatible pointer type
/var/tmp/OFEDRPM/BUILD/ofa_kernel-1.2/drivers/net/cxgb3/cxgb3_offload.c:1070: 
warning: passing arg 1 of `_write_unlock_bh' from incompatible pointer type