[ofa-general] Re: [PATCHv3] osm: Clearing lid matrices before rebuilding them

[Sasha Khapyorsky]

On 16:58 Mon 19 Mar     , Yevgeny Kliteynik wrote:
> Hi Hal,
> 
> [V3 of the patch]
> 
> This patch fixes a bug in the lid matrices creation:
> 
> The lid matrices were not cleared, which caused OSM routing
> to crash when routing nonexisting (disconnected) lids.
> 
> Please apply both to ofed_1_2 and to master.
> 
> Thanks.
> -- Yevgeny
> 
> Signed-off-by:  Yevgeny Kliteynik <kliteyn at dev.mellanox.co.il> 

Looks correct for me.

Sasha

> ---
> osm/opensm/osm_switch.c |    3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/osm/opensm/osm_switch.c b/osm/opensm/osm_switch.c
> index 913f34b..86d0153 100644
> --- a/osm/opensm/osm_switch.c
> +++ b/osm/opensm/osm_switch.c
> @@ -499,6 +499,9 @@ osm_switch_prepare_path_rebuild(
> 
>   for ( i = 0; i < p_sw->num_ports; i++ )
>     osm_port_prof_construct( &p_sw->p_prof[i] );
> +
> +  osm_switch_clear_hops(p_sw);
> +
>   if (!p_sw->hops)
>   {
>     hops = malloc((max_lids + 1)*sizeof(hops[0]));
> -- 
> 1.4.4.1.GIT
>