[ofa-general] [PATCH] OpenSM/osm_sm_state_mgr.c: In __osm_sm_state_mgr_send_master_sm_info_req, handle master GUID port not found
Yevgeny Kliteynik
kliteyn at dev.mellanox.co.il
Wed Mar 28 05:05:13 PDT 2007
Hal Rosenstock wrote:
> OpenSM/osm_sm_state_mgr.c: In
> __osm_sm_state_mgr_send_master_sm_info_req, handle master GUID port not
> found properly
>
> Signed-off-by: Hal Rosenstock <halr at voltaire.com>
>
> diff --git a/osm/opensm/osm_sm_state_mgr.c b/osm/opensm/osm_sm_state_mgr.c
> index 41153fc..002821b 100644
> --- a/osm/opensm/osm_sm_state_mgr.c
> +++ b/osm/opensm/osm_sm_state_mgr.c
> @@ -231,6 +231,11 @@ __osm_sm_state_mgr_send_master_sm_info_r
> */
> p_port = ( osm_port_t * ) cl_qmap_get( &p_sm_mgr->p_subn->port_guid_tbl,
> p_sm_mgr->master_guid );
> + if( p_port ==
> + ( osm_port_t * ) cl_qmap_end( &p_sm_mgr->p_subn->port_guid_tbl ) )
> + {
> + p_port = NULL;
> + }
Good catch.
Just curios - did you find it simply by code review or did you
actually see a case when there was no port object for the master_guid?
--Yevgeny
> }
> else
> {
>
>
>
> _______________________________________________
> general mailing list
> general at lists.openfabrics.org
> http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general
>
> To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
>
More information about the general
mailing list