[ofa-general] Re: [RFC] [PATCH v4] IB/ipoib: Add bonding support to IPoIB

Michael S. Tsirkin mst at dev.mellanox.co.il
Wed Mar 28 11:34:37 PDT 2007


> Quoting Moni Shoua <monisonlists at gmail.com>:
> Subject: Re: [RFC] [PATCH v4] IB/ipoib: Add bonding support to IPoIB
> 
> Michael S. Tsirkin wrote:
> >> Quoting Moni Shoua <monisonlists at gmail.com>:
> >> Subject: [RFC] [PATCH v4] IB/ipoib: Add bonding support to IPoIB
> >>
> >> Hi,
> >>
> >> The previous version of the patch changed ipoib_neigh_destructor to take 
> >> the pointer to neigh outside the lock. This might be a risk so I wrote a 
> >> new version of this patch so the change would affect only when bonding is used.
> >> Please see below...
> > 
> > This looks pretty safe for OFED 1.2 insofar as this won't affect
> > someone not using bonding.
> > 
> > Long term, we still need to find a proper solution for whenever
> > this bonding related code goes GA/upstream.
> > 
> Thanks Michael.
> 
> Vlad,
> Can you add this patch to kernel_patches/fixes please?
> Please note that this patch breaks one of the backport patches: ipoib_8111_to_2_6_16.patch.
> I adapted the broken patch so it can be applied after the bonding patch. 
> I tested that it works for RH4UP3. You can take it from below.

Moni, pls post a link to git tree Vlad can pull.

-- 
MST



More information about the general mailing list