> > + if (!atomic_read(&device->cache.coherent)) > > + return -ESTALE; > > + > > Should be unlikely() I guess? I don't think we have to annotate every little thing -- this doesn't seem to be a hot enough path to me for it to be worth cluttering it up with unlikely... - R.