[ofa-general] Re: [PATCH] IB/core: Enhance SMI for switch support

Roland Dreier rdreier at cisco.com
Thu Mar 29 11:19:52 PDT 2007


 > the reason this was made into a function and put inside the header file was because 
 > paths weren't accessed directly within mad.c.
 > 
 > If you are going to do what Roland is suggesting, then why have a function? Why not 
 > just stick it in-line as I had before.

The function name makes it somewhat self-documenting.  But I agree
that just putting it in-line (maybe with a comment) would be fine too.

On the other hand if you want to keep all the SMP-specific stuff out
of mad.c that makes sense too.

 - R.



More information about the general mailing list