[ofa-general] Re: [PATCH] IB/core: Enhance SMI for switch support

[Roland Dreier]

 > Rather than IB_SMI_DISCARD, it seems to me that IB_SMI_LOCAL and
 > IB_SMI_SEND would be more in keeping with the current comments.

OK ... I guess the point is that exactly what those functions are
returning is rather obscure at the moment.

 > Is a separate patch for this along these lines really needed before the
 > switch SMI changes ?

Not necessarily, but I don't think changing a function to return 0, 1
or 2 is a good idea.  So at least please fix that when adding switch
SMI support.

 - R.