[ofa-general] Re: [PATCH] infiniband: modify ammasso driver to use send with invalidate

[Steve Wise]

On Wed, 2007-05-02 at 10:16 -0700, Roland Dreier wrote:
>  > > +			if (ib_wr->send_flags & IB_SEND_SOLICITED
>  > > +				&& ib_wr->send_flags & IB_SEND_INVALIDATE) {
>  > 
>  > How about
>  > 	if (ib_wr->send_flags & (IB_SEND_SOLICITED | IB_SEND_INVALIDATE))
> 
> These two aren't equivalent -- the first has an &&, yours works like ||.
> Which is correct?

The test needs to be: 'if both are set'

Michael's sez: 'if either are set'


> _______________________________________________
> general mailing list
> general at lists.openfabrics.org
> http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general
> 
> To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general