[ofa-general] Re: [PATCH 1 of 3] IB/verbs: add cq comp_vector support in core
Roland Dreier
rdreier at cisco.com
Thu May 3 11:35:51 PDT 2007
> Note: since num_comp_vectors = 0 is not legal, and to mimizime provider churn,
> I set num_comp_vectors to a sane value in core. Providers can increase that.
I would actually prefer to see providers updated to set this
explicitly. Right now the rule is ib_alloc_device() returns a
completely zeroed out structure -- that's much easier to understand
than initializing some fields but not others. And there are other
fields we could set defaults for, like phys_port_cnt == 0 is not legal
either, but we don't try to set that in the core.
- R.
More information about the general
mailing list