[ofa-general] [query] SMI nodeinfo, port_info structures

[Hal Rosenstock]

On Fri, 2007-05-04 at 01:12, Roland Dreier wrote:
> [please try to keep your line lengths below 80 columns]
> 
>  > we can avoid this situation (duplicate declarations of same
>  > structre) by declaring the above mentioned structures in the core
>  > layer.
> 
> I think a patch moving structures defined by the IB spec to a more
> appropriate location would be fine.

Sure; currently ipath is the only one which needed these for its soft
SMA so there was no push to do this.

-- Hal

>  > Some fields in those structures have big endian (__bexx) alignment
>  > and others have CPU (uxx) alignment.
>  > 
>  > e.g: in struct port_info declared in ipath driver (ipath_mad.c),
>  > the mkey is declared as __be64 mkey whereas the local port number
>  > is declared as u8 local_port_num.
> 
> Think about it... what could endianess mean for a single-byte field?