[ofa-general] Re: [PATCHv3 1/2] core: uncached "find gid" and "find pkey" queries

Michael S. Tsirkin mst at dev.mellanox.co.il
Tue May 8 13:33:18 PDT 2007



Don't put whitespace after [ and before ].

+		device->pkey_tbl_len[ port_index ] = tprops->pkey_tbl_len;
+		device->gid_tbl_len[ port_index ] = tprops->gid_tbl_len;

whitespace damage here

+		tbl_len = device->gid_tbl_len[ port - start_port(device) ];

and here

+	tbl_len = device->pkey_tbl_len[ port_num - start_port(device) ];

and here

<plug>
Have you read the boring list of rules?
http://git.openfabrics.org/~mst/boring.txt
</plug>

-- 
MST



More information about the general mailing list