[ofa-general] [PATCH] IB/ipath -- shadow the gpio_mask register
Arthur Jones
arthur.jones at qlogic.com
Tue May 8 19:19:04 PDT 2007
hi roland, ...
On Tue, May 08, 2007 at 05:58:51PM -0700, Roland Dreier wrote:
> > GPIO interrupts which have the gpio_mask bits set are
> > no longer unlikely. remove the unlikely annotation in
> > the interrupt handler and keep a shadow copy of the
> > gpio_mask register.
>
> A better changelog would be appreciated here... I can see deleting the
> unlikely() if it's no longer appropriate, but why keep a shadow copy
> of the register? Because this is now a hotter path and you want to
> avoid the MMIO read?
exactly. shall i add that and resend?
arthur
More information about the general
mailing list