[ofa-general] Re: [PATCHv3 1/2] ipoib: handle pkey change events

[Michael S. Tsirkin]

> @@ -642,6 +651,12 @@ void ipoib_ib_dev_flush(struct work_stru
>  
>  	ipoib_ib_dev_down(dev, 0);
>  
> +	if (restart_qp) {
> +		if (test_bit(IPOIB_FLAG_INITIALIZED, &priv->flags))
> +			ipoib_ib_dev_stop(dev, 0);
> +		ipoib_ib_dev_open(dev);
> +	}
> +
>  	/*
>  	 * The device could have been brought down between the start and when
>  	 * we get here, don't bring it back up if it's not configured up

This is something that still puzzles me

1. We have tested IPOIB_FLAG_INITIALIZED above already, didn't we?
   Did you observe it flipping in testing? If yes there's some race ...

2. Let's assume that device is not initialized:
   how come you are calling ipoib_ib_dev_open on it here?

-- 
MST