[ofa-general] [PATCH] IB/mlx4 mlx4_ib: eq interrupts

[Eli Cohen]

On Wed, 2007-05-09 at 04:03 -0700, Roland Dreier wrote:

> I understand all that.  The question is, what's the difference between
> my version (which is in my tree now), which does:
> 
> 	mlx4_eq_int(...eq...)
> 	{
> 		...
> 		eq_set_ci(eq, 1);
> 	
> 		return eqes_found;
> 	}
> 
> and your version, which does
> 
> 	mlx4_eq_int(eq);
>         eq_set_ci(eq, 1);
> 
> for every call to mlx4_eq_int()?  Why does it matter if the
> eq_set_ci() is inside mlx4_eq_int() or outside?
> 
>  - R.

Oh I see, you're right - your version also arms all the EQs.