[ofa-general] Re: IPOIB CM (NOSRQ)[PATCH V4] patch for review

Michael S. Tsirkin mst at dev.mellanox.co.il
Wed May 9 10:46:25 PDT 2007


> +void ipoib_cm_handle_rx_wc(struct net_device *dev, struct ib_wc *wc)
> +{
> +	struct ipoib_dev_priv *priv = netdev_priv(dev);
> +
> +	if (priv->cm.srq)
> +		handle_rx_wc_srq(dev, wc);
> +	else
> +		handle_rx_wc_nosrq(dev, wc);
>  }

I still think this conditional branch on datapath should be avoided
by using separate RX handlers for SRQ/non SRQ cases.
And same for the one on alloc_rx_skb.

-- 
MST



More information about the general mailing list