[ofa-general] Re: [PATCH] osm: two similar bugs in Up/Dn routing

[Sasha Khapyorsky]

On 08:39 Sun 13 May     , Hal Rosenstock wrote:
> Hi Yevgeny,
> 
> On Sun, 2007-05-13 at 04:03, Yevgeny Kliteynik wrote:
> > Hi Hal,
> > 
> > This small patch fixes two similar bugs in Up/Dn routing in OpenSM.
> > A 8-bits integers were used as indexes when scanning subnet, which
> > in one case caused OpenSM to crash when ranking "path" is longer 
> > than 256 switches, and in other case caused OpenSM to go into infinite
> > loop when fabric has more than 256 roots.
> 
> Good catch.

Yes. And IMO this shows how fixed-size integers overusing can hurt.

Sasha