[ofa-general] Re: [PATCH] IB/mthca: initialise GRH:HopLimit when building MLX headers

Roland Dreier rdreier at cisco.com
Thu May 17 11:51:07 PDT 2007


thanks, applied.  I also added the following patch, since I think mlx4
has the same bug.  If you happen to have any ConnectX cards available,
can you check this works too?

commit c3f9fc8d912387837c65abf59e8cd0146b17589f
Author: Roland Dreier <rolandd at cisco.com>
Date:   Thu May 17 11:49:55 2007 -0700

    IB/mlx4: Set GRH:HopLimit when sending globally routed MADs
    
    This is the same issue discovered in mthca by Rolf Manderscheid
    <rvm at obsidianresearch.com>.
    
    Signed-off-by: Roland Dreier <rolandd at cisco.com>

diff --git a/drivers/infiniband/hw/mlx4/qp.c b/drivers/infiniband/hw/mlx4/qp.c
index 9c362fa..0cf8b95 100644
--- a/drivers/infiniband/hw/mlx4/qp.c
+++ b/drivers/infiniband/hw/mlx4/qp.c
@@ -952,6 +952,7 @@ static int build_mlx_header(struct mlx4_ib_sqp *sqp, struct ib_send_wr *wr,
 			(be32_to_cpu(ah->av.sl_tclass_flowlabel) >> 20) & 0xff;
 		sqp->ud_header.grh.flow_label    =
 			ah->av.sl_tclass_flowlabel & cpu_to_be32(0xfffff);
+		sqp->ud_header.grh.hop_limit     = ah->av.hop_limit;
 		ib_get_cached_gid(ib_dev, be32_to_cpu(ah->av.port_pd) >> 24,
 				  ah->av.gid_index, &sqp->ud_header.grh.source_gid);
 		memcpy(sqp->ud_header.grh.destination_gid.raw,



More information about the general mailing list