[ofa-general] Re: [PATCH 3/7] Move nodenamemap out of infiniband-diags into libosmcomp

[Sasha Khapyorsky]

On 20:15 Thu 01 Nov     , Ira Weiny wrote:
> From fe2756789ffbc69466eefea3cdffe200a0718561 Mon Sep 17 00:00:00 2001
> From: Ira K. Weiny <weiny2 at llnl.gov>
> Date: Thu, 1 Nov 2007 15:00:37 -0700
> Subject: [PATCH] Move nodenamemap out of infiniband-diags into libosmcomp
> 
> Signed-off-by: Ira K. Weiny <weiny2 at llnl.gov>

Applied. Thanks.

I have a question below.

> diff --git a/infiniband-diags/configure.in b/infiniband-diags/configure.in
> index 0a5f3c8..a24d478 100644
> --- a/infiniband-diags/configure.in
> +++ b/infiniband-diags/configure.in
> @@ -72,32 +72,6 @@ AC_CHECK_FUNCS([strchr strrchr strtol strtoul memset])
>  dnl Checks for typedefs, structures, and compiler characteristics.
>  AC_C_CONST
>  
> -dnl Check for the specification of a default node name map file
> -AC_MSG_CHECKING(for --with-node-name-map )
> -AC_ARG_WITH(node-name-map,
> -    AC_HELP_STRING([--with-node-name-map=file],
> -                   [define a default node name map file]),
> -    [ case "$withval" in
> -    no)
> -        ;;
> -    *)
> -        withnodenamemap=yes
> -        NODENAMEMAPFILE=$withval
> -        ;;
> -    esac ]
> -)
> -AC_MSG_RESULT(${withnodenamemap=no})
> -
> -if test $withnodenamemap = "yes"; then
> -   NODENAMEMAP_TMP1="`eval echo ${sysconfdir}/$NODENAMEMAPFILE`"
> -   NODENAMEMAP_TMP2="`echo $NODENAMEMAP_TMP1 | sed 's/^NONE/$ac_default_prefix/'`"
> -   NODENAMEMAP="`eval echo $NODENAMEMAP_TMP2`"
> -
> -   AC_DEFINE_UNQUOTED(HAVE_DEFAULT_NODENAME_MAP,
> -	         ["$NODENAMEMAP"],
> -	         [Define a default node name map file])
> -fi
> -
>  dnl Check for perl and perl install location
>  AC_MSG_CHECKING(for --with-perl-path )
>  AC_ARG_WITH(perl-path,

So --with-node-name-map=file configure option is removed completely from
diags and how mapping will work by default is only depens on how OpenSM
(which is separate package) was configured.

Do you think it would be useful useful to keep default map name as
configure option for infiniband-diags and to not depend from OpenSM
configuration (it seems easy doable - we could put some
default_node_name_map_file variable in ibdiag_common.c or so)? And then
we probably don't need such configure option for OpenSM?

Sasha