[ofa-general] Re: [PATCH 0/7] Add Node Name Map support to opensm

[Sasha Khapyorsky]

Hi Ira,

On 20:14 Thu 01 Nov     , Ira Weiny wrote:
> Sasha and I discussed the switch map support patch series and I have changed
> the implementation.  Here is another series which adds "node name" map support
> to both the diags as well as opensm.
> 
> This new functionality allows for any node descriptor to be renamed based on a
> "node name map" file.  The final implementation uses the qmap data structure
> which should be quick enough for large map files.  The patches are as follows:
> 
>    0001 - use lookup_switch_name for all node types.
>    0002 - Change switch map function names to reflect the new functionality of
>         a simple node name map.
>    0003 - Move nodenamemap out of infiniband-diags into libosmcomp
>    0004 - Change node name map implementation to use qmap in memory storage
>    0005 - infiniband-diags/src/smpquery.c : special case situation where
>         nodename len is >= 32
>    0006 - Add node-name-map support to OpenSM; using the "default" map.
>    0007 - Add node_name_map_name to opts file.
> 
> Patch number 5 can and should be applied on it's own.  It fixes a bug found
> during testing.

I applied patches 1,2,3,5. Have some comments about patches 3,4,6 (sent).
Patch 7 looks fine for me, but it requires 4 to be applied before.

Thanks for you work.

Sasha