[ofa-general] Re: [PATCH 3/7] Move nodenamemap out of infiniband-diags into libosmcomp

[Sasha Khapyorsky]

On 10:32 Mon 05 Nov     , Ira Weiny wrote:
> On Sun, 4 Nov 2007 18:07:43 +0200
> Sasha Khapyorsky <sashak at voltaire.com> wrote:
> 
> > On 20:15 Thu 01 Nov     , Ira Weiny wrote:
> > 
> > > diff --git a/infiniband-diags/configure.in b/infiniband-diags/configure.in
> > > index 0a5f3c8..a24d478 100644
> > > --- a/infiniband-diags/configure.in
> > > +++ b/infiniband-diags/configure.in
> > > @@ -72,32 +72,6 @@ AC_CHECK_FUNCS([strchr strrchr strtol strtoul memset])
> > >  dnl Checks for typedefs, structures, and compiler characteristics.
> > >  AC_C_CONST
> > >  
> > > -dnl Check for the specification of a default node name map file
> > > -AC_MSG_CHECKING(for --with-node-name-map )
> > > -AC_ARG_WITH(node-name-map,
> > > -    AC_HELP_STRING([--with-node-name-map=file],
> > > -                   [define a default node name map file]),
> > > -    [ case "$withval" in
> > > -    no)
> > > -        ;;
> > > -    *)
> > > -        withnodenamemap=yes
> > > -        NODENAMEMAPFILE=$withval
> > > -        ;;
> > > -    esac ]
> > > -)
> > > -AC_MSG_RESULT(${withnodenamemap=no})
> > > -
> > > -if test $withnodenamemap = "yes"; then
> > > -   NODENAMEMAP_TMP1="`eval echo ${sysconfdir}/$NODENAMEMAPFILE`"
> > > -   NODENAMEMAP_TMP2="`echo $NODENAMEMAP_TMP1 | sed 's/^NONE/$ac_default_prefix/'`"
> > > -   NODENAMEMAP="`eval echo $NODENAMEMAP_TMP2`"
> > > -
> > > -   AC_DEFINE_UNQUOTED(HAVE_DEFAULT_NODENAME_MAP,
> > > -	         ["$NODENAMEMAP"],
> > > -	         [Define a default node name map file])
> > > -fi
> > > -
> > >  dnl Check for perl and perl install location
> > >  AC_MSG_CHECKING(for --with-perl-path )
> > >  AC_ARG_WITH(perl-path,
> > 
> > So --with-node-name-map=file configure option is removed completely from
> > diags and how mapping will work by default is only depens on how OpenSM
> > (which is separate package) was configured.
> > 
> > Do you think it would be useful useful to keep default map name as
> > configure option for infiniband-diags and to not depend from OpenSM
> > configuration (it seems easy doable - we could put some
> > default_node_name_map_file variable in ibdiag_common.c or so)? And then
> > we probably don't need such configure option for OpenSM?
> > 
> 
> Actually I would prefer a default which does not have to be configured.  Would
> this be acceptable?

Yes. I'm fine this this.

> Perhaps <sysconfdir>/ib-node-name-map?

Or under /etc/ofa/ ?

Sasha