[ofa-general] [PATCH] IPoIB: Remove redundant check in xmit handler
Roland Dreier
rdreier at cisco.com
Thu Nov 15 01:00:26 PST 2007
> - /*
> - * Check if our queue is stopped. Since we have the LLTX bit
> - * set, we can't rely on netif_stop_queue() preventing our
> - * xmit function from being called with a full queue.
> - */
> - if (unlikely(netif_queue_stopped(dev))) {
> - spin_unlock_irqrestore(&priv->tx_lock, flags);
> - return NETDEV_TX_BUSY;
> - }
This check was added because of a real problem seen in practice a
while ago. Has something changed in the tx queue locking that makes
it redundant now?
I seem to remember that I could make the problem race trigger pretty
fast by making the tx queue very small so that it got stopped a lot.
- R.
More information about the general
mailing list