[ofa-general] Re: [PATCHES] TX batching
Evgeniy Polyakov
johnpol at 2ka.mipt.ru
Mon Oct 8 05:51:25 PDT 2007
Hi Jamal.
On Sun, Oct 07, 2007 at 02:34:53PM -0400, jamal (hadi at cyberus.ca) wrote:
>
> Please provide feedback on the code and/or architecture.
> Last time i posted them i received little. They are now updated to
> work with the latest net-2.6.24 from a few hours ago.
>
> Patch 1: Introduces batching interface
> Patch 2: Core uses batching interface
> Patch 3: get rid of dev->gso_skb
it looks like you and Krishna use the same requeueing methods - get one
from qdisk, queue it into blist, get next from qdisk, queue it,
eventually start transmit, where you dequeue it one-by-one and send (or
prepare and commit). This is not the 100% optimal approach, but if you
proved it does not hurt usual network processing, it is ok.
Number of comments dusted to very small - that's a sign, but I'm a bit
lost - did you and Krishna create the competing approaches, or they can
co-exist together, in the former case I doubt you can push, until all
problematic places are resolved, in the latter case, this is probably
ready.
--
Evgeniy Polyakov
More information about the general
mailing list