[ofa-general] Re: [PATCH 2/3][NET_BATCH] net core use batching
Krishna Kumar2
krkumar2 at in.ibm.com
Mon Oct 8 20:09:31 PDT 2007
J Hadi Salim <j.hadi123 at gmail.com> wrote on 10/08/2007 06:47:24 PM:
> two, there should _never_ be any requeueing even if LLTX in the previous
> patches when i supported them; if there is, it is a bug. This is because
> we dont send more than what the driver asked for via xmit_win. So if it
> asked for more than it can handle, that is a bug. If its available space
> changes while we are sending to it, that too is a bug.
Driver might ask for 10 and we send 10, but LLTX driver might fail to get
lock and return TX_LOCKED. I haven't seen your code in greater detail, but
don't you requeue in that case too?
- KK
More information about the general
mailing list