[ofa-general] [PATCH 13 of 17]: add LRO support

[Eli Cohen]

> Can you clarify if/how this patch is related to the "lro: Generic Large 
> Receive Offload for TCP traffic" RFC sent on August this year to netdev 
> (eg see http://lwn.net/Articles/244206) ?

I referred to mtnic driver when I made this patch which referred to
other code examples, possibly from this one too.

> 
> Assuming LRO is a --pure software-- optimization, what's the rational to 
> put its whole implementation in the ipoib driver and not divide it to 
> general part implemented in the net core and per driver part implemented 
> per device driver that wants to support LRO (if such second part is 
> needed at all)?

It is a pure software optimization but it relies on the HW to report
whether the checksum of the packet is valid or not in order for it to be
liable for aggregation. I think it would be good however if the kernel
would support this and take this from the specific drivers.
> 
> If I am wrong and their is some LRO assistance from the connectX HW, 
> what is it doing?
> 
> Or.
> 
>