[ofa-general] [PATCH] IB/core - Don't modify outgoing DR SMP if first part is LID routed

[Hal Rosenstock]

On Wed, 2007-10-17 at 15:32 -0700, Sean Hefty wrote:
> Hal Rosenstock wrote:
> > On Wed, 2007-10-17 at 15:07 -0700, Sean Hefty wrote:
> >> Ralph Campbell wrote:
> >>> The code in handle_outgoing_dr_smp() checks to see if the directed
> >>> route SMP has an initial LID routed part and correctly does not
> >>> modify the hop pointer but it then proceeds to process the packet
> >>> as if there was no initial LID routed part.  Instead, if there
> >>> is an initial LID routed part, the packet should just be sent on
> >>> to the destination and not processed further since it can't be
> >>> destined for the local SM/SMA.
> 
> >> This makes sense to me at first read, but I need more time studying the 
> >> spec and existing code before reaching any conclusions.  Can't a DR SMP 
> >> be entirely LID routed, meaning that this SMP could be for the local 
> >> node?  (I know that doesn't seem to make sense, but is it permitted?)
> > 
> > Yes (and you can do this with smpquery and sminfo).
> 
> So, I think we want to remove the comment from the changelog that states 
> that the SMP 'can't be destined for the local SM/SMA'. 

I think that language came from the spec. Need to do some homework on
this.

> I _think_ the code change itself is okay, as long as we handle this on the receive 
> side, which is needed anyway, and is part of the missing support that 
> you pointed out in a separate thread.  Does this seem correct?

I'm not sure until I do my homework.

-- Hal

> - Sean