[ofa-general] Re: [PATCHv2] infiniband-diags/perfquery.c: Support PMAs which don't support AllPortSelect option

[Sasha Khapyorsky]

On 16:25 Tue 16 Oct     , Hal Rosenstock wrote:
> infiniband-diags/perfquery.c: Support PMAs which don't support
> AllPortSelect option
> 
> Currently only support single port HCAs are supported in this mode but
> this can be extended for other devices if needed
> 
> Tested-by: Greg Kurtzer <gmk at lbl.gov>
> Signed-off-by: Hal Rosenstock <hal at xsigo.com>

Applied. Thanks.

However I have a question below.

> +	if (allports == 1) {
> +
> +		/*
> +		 * Simulate all ports support in PMA
> +		 * Determine node type, number of (physical) ports,
> +		 * and, if switch, whether SP0 is enhanced
> +		 * to determine first and last port to query
> +		 */
> +
> +		/* For now, support single port CAs */
> +		if (smp_query(data, &portid, IB_ATTR_NODE_INFO, 0, 0) < 0)
> +			IBERROR("smp query nodeinfo failed");
> +		node_type = mad_get_field(data, 0, IB_NODE_TYPE_F);
> +		if (node_type != IB_NODE_CA)    /* NodeType other than CA ? */
> +			IBERROR("smp query nodeinfo: Node type not CA");

Not supporting switches and routers is temporary limitation (like
all port simulation for single port CAs only), right?

Sasha