[ofa-general] Re: [PATCH 5 of 5] mlx4: Do not allocate an extra (unneeded) CQE when creating a CQ

[Roland Dreier]

I'm missing something with this patch set... 

 > Leave create_cq for userspace CQs as before, to avoid breaking ABI.
 > (Handle this in separate libmlx4 patch)

You don't want to break the ABI, which is very good.  But...

 > -	dev->caps.max_cqes	     = dev_cap->max_cq_sz - 1;
 > +	dev->caps.max_cqes	     = dev_cap->max_cq_sz;

Unless I'm confused, this will lead to userspace seeing a larger limit
for the max number of CQEs.  Which will mean that an old libmlx4 will
fail to create a CQ if the consumer asks for the largest possible CQ, right?

 - R.