[ofa-general] Re: [PATCH] osm: QoS parser - fixing yacc command

[Sasha Khapyorsky]

On 00:55 Sat 01 Sep     , Yevgeny Kliteynik wrote:
>  Sasha Khapyorsky wrote:
> > On 18:39 Thu 30 Aug     , Yevgeny Kliteynik wrote:
> >> Fixing bison command to more general yacc syntax
> >>
> >> Signed-off-by: Yevgeny Kliteynik <kliteyn at dev.mellanox.co.il>
> > Applied. Thanks.
> >> ---
> >>  opensm/opensm/Makefile.am |    3 ++-
> >>  1 files changed, 2 insertions(+), 1 deletions(-)
> >>
> >> diff --git a/opensm/opensm/Makefile.am b/opensm/opensm/Makefile.am
> >> index abfa913..4ab7227 100644
> >> --- a/opensm/opensm/Makefile.am
> >> +++ b/opensm/opensm/Makefile.am
> >> @@ -60,7 +60,8 @@ opensm_SOURCES = main.c osm_console.c osm_db_files.c \
> >>  		 osm_qos_parser_y.c osm_qos_parser_l.c osm_qos_policy.c
> >>
> >>  osm_qos_parser_y.c: $(srcdir)/osm_qos_parser.y 
> >> $(srcdir)/../include/opensm/osm_qos_policy.h
> >> -	$(YACC) -y -d $(srcdir)/osm_qos_parser.y -o $(srcdir)/osm_qos_parser_y.c 
> >> --defines=$(srcdir)/../include/opensm/osm_qos_parser_y.h 
> >> --name-prefix=__qos_parser_
> >> +	$(YACC) -d -o $(srcdir)/osm_qos_parser_y.c -p__qos_parser_ 
> >> $(srcdir)/osm_qos_parser.y
> >> +	mv -f y.tab.h $(srcdir)/../include/opensm/osm_qos_parser_y.h
> > BTW if osm_qos_parser_y.h file is generated one and used only by
> > generated *.c files is not it would be simpler just to lease it in
> > current directory?
> 
>  Perhaps, but then it would be the only header file in opensm
>  source that's not located under the include/ directory.

This generated file is used internally by generated parser only, I think
it is fine to keep them together.

>  Is it the only header that isn't included by other headers in osm?

Not header, by source files.

Sasha