[ofa-general] Re: [PATCH] librdmacm 1/2: add valgrind support to auto-tools configuration file

[Dotan Barak]

Sean Hefty wrote:
>> I have a comment only on your last choice: i don't know the feature 
>> history of valgrind but i believe that
>> there were versions which had the file memcheck.h without the 
>> mentioned macro.
>>
>> I would  like to leave the code that handles this issue like it was 
>> in the original patch (if it is fine with you).
>
> I checked a couple of older valgrind releases, and you are correct. 
> There are versions where it is undefined.  I've reverted this change 
> back to match your original patch.  Thanks.
Great.

In the near future, i will send you a patch to the libibcm that will add 
valgrind support
to this library as well.


thanks again
Dotan