[ofa-general] [PATCH] Fix umad_get_cas_names() usage in libibumad.
Hal Rosenstock
hal.rosenstock at gmail.com
Mon Sep 10 08:26:40 PDT 2007
On 9/7/07, Arne Redlich <arne.redlich at xiranet.com> wrote:
> resolve_ca_name() passes a wrong "max" argument to umad_get_cas_names.
>
> Signed-off-by: Arne Redlich <arne.redlich at xiranet.com>
> ---
> diff --git a/libibumad/src/umad.c b/libibumad/src/umad.c
> index 787aa92..589684c 100644
> --- a/libibumad/src/umad.c
> +++ b/libibumad/src/umad.c
> @@ -307,7 +307,7 @@ resolve_ca_name(char *ca_name, int *best_port)
> }
>
> /* Get the list of CA names */
> - if ((n = umad_get_cas_names((void *)names, UMAD_CA_NAME_LEN)) < 0)
> + if ((n = umad_get_cas_names((void *)names, 20)) < 0)
Rather than the hard coded 20 here and elsewhere, should this be
replaced by a #define ?
-- Hal
> return 0;
>
> /* Find the first existing CA with an active port */
> --
> 1.5.2.1
>
> _______________________________________________
> general mailing list
> general at lists.openfabrics.org
> http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general
>
> To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
>
More information about the general
mailing list