[ofa-general] Re: [PATCH 3/7 V3] osm: QoS policy C & H files
Sasha Khapyorsky
sashak at voltaire.com
Sat Sep 15 19:16:59 PDT 2007
Hi Yevgeny,
On 17:51 Tue 11 Sep , Yevgeny Kliteynik wrote:
> Hi Sasha,
>
> >> +typedef struct _osm_qos_policy_t {
> >> + cl_list_t port_groups; /* list of osm_qos_port_group_t */
> >> + cl_list_t sl2vl_tables; /* list of osm_qos_sl2vl_scope_t */
> >> + cl_list_t vlarb_tables; /* list of osm_qos_vlarb_scope_t */
> >> + cl_list_t qos_levels; /* list of osm_qos_level_t */
> >> + cl_list_t qos_match_rules; /* list of osm_qos_match_rule_t */
> >
> > Here and above - where possible please use cl_qlist_t instead of
> > cl_list_t - it is _much_ faster (I did some benchmarking when worked
> > on up/down performance issues).
>
> What about cl_map_t vs cl_qmap_t?
> Is the difference there significant?
I guess it should be so (never checked however) - basically cl_map* does
cl_qmap* + additional things (including memory allocations, etc.).
Sasha
More information about the general
mailing list